V8 test-in-container patch

DJ Delorie dj@redhat.com
Thu Aug 23 22:57:00 GMT 2018


Joseph Myers <joseph@codesourcery.com> writes:
> I expect that even if this build gets deferred to when the testsuite is 
> run, you'll still need to use $(libunwind)

Sure, but I'm thinking it also might be a piece of the bootstrap puzzle
that we don't (or shouldn't) need to worry about.

How's this patch look?  The various macros seem undocumented, but this
looks like what the various test linkers are using.

diff --git a/support/Makefile b/support/Makefile
index b5fcb6ed86..166420de70 100644
--- a/support/Makefile
+++ b/support/Makefile
@@ -165,18 +165,14 @@ ifeq (,$(CXX))
 LINKS_DSO_PROGRAM = links-dso-program-c
 else
 LINKS_DSO_PROGRAM = links-dso-program
-LDLIBS-links-dso-program = -lstdc++ -lgcc_s
+LDLIBS-links-dso-program = -lstdc++ $(gnulib-tests)
 endif
 

(yes, I know it won't apply cleanly, it's part of a bigger mess I'm
working with ;)



More information about the Libc-alpha mailing list