[PATCH] __readlink_chk: Assume HAVE_INLINED_SYSCALLS

Florian Weimer fweimer@redhat.com
Mon Aug 20 16:53:00 GMT 2018


On 08/20/2018 06:21 PM, Adhemerval Zanella wrote:
> 
> 
> On 20/08/2018 13:18, Adhemerval Zanella wrote:
>>
>>
>> On 20/08/2018 11:40, Florian Weimer wrote:
>>> HAVE_INLINED_SYSCALLS is always defined on Linux.
>>>
>>> 2018-08-20  Florian Weimer  <fweimer@redhat.com>
>>>
>>> 	* sysdeps/unix/sysv/linux/generic/readlink_chk.c: Remove
>>> 	HAVE_INLINED_SYSCALLS conditionals
>>
>> LGTM.
> 
> In fact, do we really need to have a duplicated Linux implementation
> for this micro-optimization? Couldn't we just use default debug
> one and call '__readlink' instead?

Like this?

Thanks,
Florian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: readlink_chk.patch
Type: text/x-patch
Size: 2123 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20180820/dbbb1fc3/attachment.bin>


More information about the Libc-alpha mailing list