[PATCH] powerpc64: Remove support for !HAVE_INLINED_SYSCALLS

Florian Weimer fweimer@redhat.com
Mon Aug 20 16:48:00 GMT 2018


On 08/20/2018 06:29 PM, Adhemerval Zanella wrote:
> 
> 
> On 20/08/2018 11:40, Florian Weimer wrote:
>> HAVE_INLINED_SYSCALLS is always defined on Linux.
>>
>> 2018-08-20  Florian Weimer  <fweimer@redhat.com>
>>
>> 	* sysdeps/powerpc/powerpc64/dl-machine.h (DL_STARTING_UP_DEF):
>> 	Remove macro.
>> 	(RTLD_START): Adjust.
> 
> This file is not Linux specific, so it can potentially be used on a port
> which defines HAVE_INLINED_SYSCALLS.  Is the plan to get rid of
> HAVE_INLINED_SYSCALLS altogether?

Do you plan to start a Hurd port for powerpc? 8-)

The condition looks wrong to me—it probably should be 
RTLD_PRIVATE_ERRNO, not HAVE_INLINED_SYSCALLS.  And I plan to get rid of 
the private errno for ld.so eventually on Linux.  I'm not sure if this 
comment is correct anymore:

/* The dynamic linker uses its own private errno variable.
    All access to errno inside the dynamic linker is serialized,
    so a single (hidden) global variable is all it needs.  */

Thanks,
Florian



More information about the Libc-alpha mailing list