[PATCH] powerpc: Remove powerpc specific sinf and cosf optimization

Adhemerval Zanella adhemerval.zanella@linaro.org
Fri Aug 17 11:30:00 GMT 2018



On 17/08/2018 07:22, Rajalakshmi Srinivasaraghavan wrote:
> New generic optimization of sinf and cosf introduced by commit
> 599cf3976679e1b345307d9c02057f02aa95528f shows improvement
> compared to powerpc specific assembly version.  Hence removing
> the powerpc assembly versions to make use of generic code.
> 
> Tested on powerpc64le.
> 
> Without patch:
>  "cosf": {
>    "": {
>     "duration": 5.10732e+09,
>     "iterations": 1.07699e+09,
>     "max": 43.833,
>     "min": 2.481,
>     "mean": 4.74221
>    }
> 
>   "sinf": {
>    "": {
>     "duration": 5.11105e+09,
>     "iterations": 1.02326e+09,
>     "max": 668.485,
>     "min": 2.695,
>     "mean": 4.99485
>    }
> 
> With patch:
>   "cosf": {
>    "": {
>     "duration": 5.10862e+09,
>     "iterations": 1.2597e+09,
>     "max": 103.299,
>     "min": 2.213,
>     "mean": 4.05544
>    }
>   "sinf": {
>    "": {
>     "duration": 5.1161e+09,
>     "iterations": 1.27327e+09,
>     "max": 41.767,
>     "min": 2.213,
>     "mean": 4.01809
>    }
> 
> 2018-08-17  Rajalakshmi Srinivasaraghavan  <raji@linux.vnet.ibm.com>
> 
> 	* sysdeps/powerpc/powerpc64/fpu/multiarch/Makefile
> 	(libm-sysdep_routines): Remove s_sinf-ppc64, s_sinf-power8,
> 	s_cosf-ppc64 and s_cosf-power8.
> 	* sysdeps/powerpc/fpu/s_cosf.c: Remove file.
> 	* sysdeps/powerpc/fpu/s_sinf.c: Likewise.
> 	* sysdeps/powerpc/fpu/k_sinf.c: Likewise.
> 	* sysdeps/powerpc/fpu/k_cosf.c: Likewise.
> 	* sysdeps/powerpc/powerpc64/fpu/multiarch/s_cosf-power8.S: Likewise.
> 	* sysdeps/powerpc/powerpc64/fpu/multiarch/s_cosf-ppc64.c: Likewise.
> 	* sysdeps/powerpc/powerpc64/fpu/multiarch/s_cosf.c: Likewise.
> 	* sysdeps/powerpc/powerpc64/fpu/multiarch/s_sinf-power8.S: Likewise.
> 	* sysdeps/powerpc/powerpc64/fpu/multiarch/s_sinf-ppc64.c: Likewise.
> 	* sysdeps/powerpc/powerpc64/fpu/multiarch/s_sinf.c: Likewise.
> 	* sysdeps/powerpc/powerpc64/power8/fpu/s_cosf.S: Likewise.
> 	* sysdeps/powerpc/powerpc64/power8/fpu/s_sinf.S: Likewise.


LGTM, thanks.



More information about the Libc-alpha mailing list