[PATCH] Makeconfig (ASFLAGS): Always append required assembler flags

[Carlos O'Donell]

On 08/14/2018 11:57 AM, Florian Weimer wrote:
> On 07/04/2018 04:29 PM, Florian Weimer wrote:
>> Otherwise, it is impossible to set ASFLAGS differently from CFLAGS
>> without also overriding essential flags such as -Wa,--noexecstack.
>>
>> 2018-07-04  Florian Weimer  <fweimer@redhat.com>
>>
>> Â Â Â Â * Makeconfig (ASFLAGS): Always append required assembler flags.
>>
>> diff --git a/Makeconfig b/Makeconfig
>> index 608ffe648c..099f184088 100644
>> --- a/Makeconfig
>> +++ b/Makeconfig
>> @@ -1047,7 +1047,7 @@ endif
>> Â  ifndef ASFLAGS
>> Â  ASFLAGS := $(filter -g% -fdebug-prefix-map=%,$(CFLAGS))
>> Â  endif
>> -ASFLAGS += -Werror=undef $(ASFLAGS-config) $(asflags-cpu)
>> +override ASFLAGS += -Werror=undef $(ASFLAGS-config) $(asflags-cpu)

This looks correct to me.

>> Â  Â  ifndef BUILD_CC
>> Â  BUILD_CC = $(CC)

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

-- 
Cheers,
Carlos.