[RFC PATCH V2 02/10] C-SKY: TLS support

Joseph Myers joseph@codesourcery.com
Tue Apr 17 20:50:00 GMT 2018


On Sun, 8 Apr 2018, Mao Han wrote:

> +/* Default to an executable stack.  PF_X can be overridden if PT_GNU_STACK is
> + * present, but it is presumed absent.  */
> +#define DEFAULT_STACK_PERMS (PF_R|PF_W|PF_X)

This is not an appropriate default for a new port.  (Of course you need to 
fix your kernel port accordingly so it doesn't default to an executable 
stack either.)

Also, globally in the port, no leading '*' on second and subsequent lines 
of comments.

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list