[PATCH 2/2] benchtests: Add a new argument -t to read throughput results

Siddhesh Poyarekar siddhesh@sourceware.org
Thu Sep 21 23:55:00 GMT 2017


On Friday 22 September 2017 12:01 AM, Carlos O'Donell wrote:
> On 09/18/2017 11:40 AM, Siddhesh Poyarekar wrote:
>> String benchmarks that store results as throughput rather than
>> latencies will show positive improvements as negative.  Add a flag to
>> fix the output of compare_strings.py in such cases.
>>
>> 	* benchtests/scripts/compare_strings.py: New option -t.
> ... and you wouldn't need this patch if you'd not changed to throughput.
> 
> Can't you just post-process the data to get throughput for your fancy
> graphs... or better yet add fancy graph support directly to benchtests ;-)


I suppose I could add a property to the benchmark output itself like:

  "result-type": "rate" | "time"

which should be a hint to any post-processing scripts like
compare_strings.py.

BTW, there's a -g switch that generates graphs for the string benchmarks
in compare_strings.py.  One needs to exclude the simple_* string
functions to get more meaningful results since these tend to be
significantly slower, thus unnecessarily increasing the range of the Y-axis.

Siddhesh



More information about the Libc-alpha mailing list