[PATCH 2/2] Use C11 _Alignas on scratch_buffer internal buffer
Paul Eggert
eggert@cs.ucla.edu
Thu Sep 21 22:53:00 GMT 2017
Adhemerval Zanella wrote:
> Now back to the patch topic, I think the first union version [1] should
> the most suitable one and it is what I am intended to push.
>
> [1]https://sourceware.org/ml/libc-alpha/2017-09/msg00730.html
The code for that looks fine for Gnulib. However, the commit message could be
improved. It needs a summary line that does not mention _Alignas. "an union"
should be "a union". There is no need to cite every use affected by the change;
just say "All uses changed". It would be nice to credit Florian for pointing out
the problem and Andreas for suggesting a solution.
Attached is a proposed patch to Gnulib, which uses the same code as the
abovementioned glibc patch, but which has an improved commit message; please use
it as a guideline for the glibc commit.
One more thing. Gnulib and other GNU projects are switching to using https: URLs
to gnu.org and to fsf.org, and this causes the shared glob sources to differ in
one line. Glibc should be fixed to use https: instead of http: for citations to
GNU and FSF web sites. That should be a separate patch, of course. I'll look
into it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-scratch_buffer-use-union-for-internal-buffer.patch
Type: text/x-patch
Size: 3483 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20170921/13de30a2/attachment.bin>
More information about the Libc-alpha
mailing list