[PATCH v2 1/1] Add new codepage charmaps/IBM858

Florian Weimer fweimer@redhat.com
Thu Sep 14 09:10:00 GMT 2017


On 09/09/2017 11:43 AM, Mike FABIAN wrote:
> Subject: [PATCH] Add new codepage charmaps/IBM858
> 
> 	[BZ #21084]
> 	* benchtests/strcoll-inputs/filelist#en_US.UTF-8: Add IBM858 and ibm858.c.
> 	* iconvdata/Makefile: Add IBM858.
> 	* iconvdata/gconv-modules: Add IBM858.
> 	* iconvdata/ibm858.c: New file.
> 	* iconvdata/tst-tables.sh: Add IBM858
> 	* localedata/charmaps/IBM858: New file.

Patch looks good.  Thanks for adding the comment about the discrepancy 
between our ASCII-compatible version and IBM's specification.

Please commit this with [BZ #21084] on the first line of the commit 
message.  Perhaps also mention the ASCII/IBM discrepancy in the commit 
message.

Thanks,
Florian



More information about the Libc-alpha mailing list