[PATCH] Fix tests that are testing obsoleted functionality

Steve Ellcey sellcey@cavium.com
Tue Sep 5 17:49:00 GMT 2017


On Thu, 2017-08-24 at 19:11 -0400, Carlos O'Donell wrote:
> On 08/24/2017 06:55 PM, Steve Ellcey wrote:
> > 
> > 2017-08-24  Steve Ellcey  <sellcey@cavium.com>
> > 
> > 	* include/shlib-compat.h (TEST_COMPAT): New Macro.
> > 	* malloc/tst-mallocstate.c: Convert from test-skeleton
> > 	to test-driver.  Ifdef code using TEST_COMPAT macro.
> > 	* math/test-matherr-2.c: Ifdef test using TEST_COMPAT macro.
> > 	* math/test-matherr.c: Likewise.
> > 
> From a high-level perspective this looks good to me.
> 
> I know we're not supposed to do anything special on master for
> AArch64 ILP32, but this kind of generic cleanup that future-proofs
> the test for new arches (we are expecting RISC-V port to turn 
> up soon and they would have seen this) is a win win.
> 
> I'd like one other developer to ACK before you commit this, since
> I'd like to hear a few more opinions on how we might handle this.


Patch ping.  Does anyone else have any comments on this approach
to fixing these tests?

Steve Ellcey
sellcey@cavium.com



More information about the Libc-alpha mailing list