Removing ChangeLog [Was Re: 2.26 hard freeze status]
Siddhesh Poyarekar
siddhesh@gotplt.org
Mon Sep 4 05:40:00 GMT 2017
On Friday 01 September 2017 10:52 PM, H.J. Lu wrote:
> I checked in this patch to update tst-regex.c/tst-regex2.c for old ChangeLog
> move.
>
>
<snip>
> /* Make the content of the file available in memory. */
> - file = "../ChangeLog.8";
> + file = "../ChangeLog.old/ChangeLog.8";
> fd = open (file, O_RDONLY);
> if (fd == -1)
> error (EXIT_FAILURE, errno, "cannot open %s", basename (file));
> diff --git a/posix/tst-regex2.c b/posix/tst-regex2.c
> index 0d82c2acdd..5e624cb5c2 100644
> --- a/posix/tst-regex2.c
> +++ b/posix/tst-regex2.c
> @@ -33,7 +33,7 @@ do_test (void)
> "((((((((((.?))))))))))((((((((((.?))))))))))((((((((((.?))))))))))"
> "((((((((((.?))))))))))Log\\.13" };
>
> - int fd = open ("../ChangeLog.14", O_RDONLY);
> + int fd = open ("../ChangeLog.old/ChangeLog.14", O_RDONLY);
> if (fd < 0)
> {
> printf ("Couldn't open ChangeLog.14: %m\n");
>
Instead, it might be cleaner to just copy those files to
tst-regex2-input.txt or similar. We will likely run into this issue
again in another 5 years when all of us have forgotten about this ghost
dependency.
Siddhesh
More information about the Libc-alpha
mailing list