[PATCHv2] New generic sinf

Joseph Myers joseph@codesourcery.com
Tue Oct 31 18:35:00 GMT 2017


On Tue, 31 Oct 2017, Rajalakshmi Srinivasaraghavan wrote:

> 2017-10-31  Rajalakshmi Srinivasaraghavan  <raji@linux.vnet.ibm.com>
> 
> 	* sysdeps/ieee754/flt-32/s_sinf.c: New implementation.

Missing [BZ #5997] marker.

> +/* Chebyshev constants for sin, range -PI/4 - PI/4.  */

I presume some of these are actually for cos and so there should be more 
detailed comments for the separate groups of constants.

> +static inline float
> +reduced (const double theta, const unsigned long n,
> +	 const unsigned long signbit)

This function needs a comment above it explaining the semantics of the 
arguments and the return value.

> +float
> +SINF_FUNC(float x)

Missing space before '('.

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list