[PATCH] localedata: Reorganize Unicode LC_CTYPE inclusion.

Rafal Luzynski digitalfreak@lingonborough.com
Mon Oct 30 23:51:00 GMT 2017


27.10.2017 18:02 Carlos O'Donell <carlos@redhat.com> wrote:
> [...]
> As subsystem maintainer for localedata you do not need review. You can assume
> consensus and fix the file directly.
>
> You are correct that the category lines are in error, they should be removed,
> I didn't notice them in my final regeneration.
>
> However! The category line generated by
> localedata/unicode-gen/gen_unicode_ctype.py
> is also wrong.

So this time it was worth to wait for your review.

> It is a static 'unicode:2014', and this is invalid.
>
> ISO 30112 standard defines the valid values for the category.
>
> There are only 4 valid values:
> "i18n:2012"
> "i18n:2004"
> "posix:1993"
> and they state the conformance of the category itself.
>
> Next step:
>
> * Remove the category entries in i18n_ctype except for LC_CTYPE.
> * Adjust the category entry for LC_CTYPE to use "i18n:2012"
> * Adjust gen_unicode_ctype.py to output "i18n:2012" instead of the invalid
> "unicode:2014"

Done.

> We should make localedef validate the conformance of this value, but that's
> another patch.

OK, indeed it's another patch so I did not implement this.

> I will assume you will make the changes unless you hand them off to me.

Please see the attachment.

Regards,

Rafal
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-localedata-Once-again-correct-and-regenerate-i18n_ct.patch
Type: text/x-patch
Size: 2400 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20171030/d5cd387b/attachment.bin>


More information about the Libc-alpha mailing list