[PATCH v2][malloc] Use relaxed atomics for malloc have_fastchunks
Chris Metcalf
cmetcalf@mellanox.com
Wed Oct 18 15:56:00 GMT 2017
On 10/17/2017 7:08 PM, Joseph Myers wrote:
> I think this breaks the build for tilepro. You're using atomic
> operations
> on a bool field, and tilepro only supports atomic operations on 4-byte
> objects and gives errors for other sizes. Generic code should only use
> atomics on int-size / pointer-size objects unless it knows the particular
> architecture supports atomics of other sizes (e.g. through
> __HAVE_64B_ATOMICS).
To be fair, we could also synthesize subword atomics for tilepro with
compare
and swap on the surrounding word, so it's not technically impossible to add
this support. And (as Wilco already demonstrated) it's trivial to fix the
caller to work around this problem.
However, it's also true that tilepro is no longer an actively-maintained
platform;
the tilegx platform has pretty well supplanted it in practice. Perhaps
it is time
to look at obsoleting tilepro so that its presence in the tree doesn't
block
forward progress for other architectures. I'm not aware of any existing
tilepro
customers that are looking to use newer versions of glibc.
--
Chris Metcalf, Mellanox Technologies
http://www.mellanox.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20171018/6044e887/attachment.htm>
More information about the Libc-alpha
mailing list