[PATCH] localedef: Add --no-warnings/--warnings option
Carlos O'Donell
carlos@redhat.com
Tue Oct 17 17:24:00 GMT 2017
On 10/17/2017 02:14 AM, Andreas Schwab wrote:
> On Okt 17 2017, Carlos O'Donell <carlos@redhat.com> wrote:
>
>> diff --git a/locale/programs/charmap.h b/locale/programs/charmap.h
>> index 5d6b48f..441d429 100644
>> --- a/locale/programs/charmap.h
>> +++ b/locale/programs/charmap.h
>> @@ -66,6 +66,8 @@ struct charseq
>>
>> /* True if the encoding is not ASCII compatible. */
>> extern bool enc_not_ascii_compatible;
>> +/* True if the ASCII compatibility check should raise a warning. */
>> +bool warn_ascii;
>
> This should be extern.
>
> I think both flags should be declared in the same header, since they are
> defined in the same source file.
The annoying part here is that charmap.o is used by iconv *and* localedef.
I made this a tentative definition because iconv doesn't need it, and
doesn't define it, and localedef defines it *and* initializes it ot true.
I'll see if I can structure this better. Let me work up a v2.
--
Cheers,
Carlos.
More information about the Libc-alpha
mailing list