[PATCH] Benchtests for sinf, cosf and sincosf
Rajalakshmi Srinivasaraghavan
raji@linux.vnet.ibm.com
Thu Oct 12 14:19:00 GMT 2017
On 10/12/2017 07:27 AM, Siddhesh Poyarekar wrote:
> n Wednesday 11 October 2017 06:35 PM, Joseph Myers wrote:
>> I don't think that's appropriate for sharing between different types. The
>> inputs for sin include many outside the range of float (which probably
>> illustrates how unrepresentative they are of typical usage of sin), and we
>> don't want the float test to have lots of infinities tested.
> OK, as for larger values, they were there to exercise the range
> reduction paths, which can be done by smaller values as well so we could
> just drop those inputs.
>
>> Sharing inputs between sinf, cosf and sincosf may make much more sense.
> Agreed.
Is it fine to commit the existing patch and work on reusing them across
functions later?
--
Thanks
Rajalakshmi S
More information about the Libc-alpha
mailing list