[PING][PATCHv3 1/2] aarch64: Hoist ZVA check out of the memset function

Siddhesh Poyarekar siddhesh@sourceware.org
Thu Oct 12 12:57:00 GMT 2017


On Thursday 12 October 2017 04:43 PM, Szabolcs Nagy wrote:
> since the patch modifies the memset code that runs in
> most cases, the impact of the change should be well
> understood before it goes in.
> 
> in the static linked case it will introduce a plt
> indirection, i don't expect a big gain except on falkor
> and there is a risk of regression on other cores, it
> also makes the code less maintainable.

Why do you think this gives a gain only on falkor, especially when I
asserted that it gives a significant gain on falkor *and* mustang?  Why
do you think having a bunch of branches in live code (that's the bit
that gets hoisted out) would be beneficial to any core?

Siddhesh



More information about the Libc-alpha mailing list