[PATCH] Test for profiling support (_mcount/gprof)

Florian Weimer fweimer@redhat.com
Thu Oct 5 12:21:00 GMT 2017


On 10/05/2017 02:19 PM, Andreas Schwab wrote:
> On Okt 05 2017, Florian Weimer <fweimer@redhat.com> wrote:
> 
>> On 08/16/2017 10:09 AM, Florian Weimer wrote:
>>> tst-gmon: Build with -fno-omit-frame-pointer
>>>
>>> If glibc is built with -fomit-frame-pointer to undo the effect of
>>> configuring GCC with --enable-frame-pointer, using -pg by itself results
>>> in a build failure:
>>>
>>> gcc: error: -pg and -fomit-frame-pointer are incompatible
>>>
>>> 2017-08-16  Florian Weimer<fweimer@redhat.com>
>>>
>>> 	* gmon/Makefile (CFLAGS-tst-gmon.c): Add -fno-omit-frame-pointer.
>>>
>>> diff --git a/gmon/Makefile b/gmon/Makefile
>>> index 39f11acec2..62d96543ff 100644
>>> --- a/gmon/Makefile
>>> +++ b/gmon/Makefile
>>> @@ -38,7 +38,7 @@ endif
>>>    # The mcount code won't work without a frame pointer.
>>>    CFLAGS-mcount.c := -fno-omit-frame-pointer
>>>    -CFLAGS-tst-gmon.c := -pg
>>> +CFLAGS-tst-gmon.c := -fno-omit-frame-pointer -pg
>>>    LDFLAGS-tst-gmon := $(no-pie-ldflag)
>>>    CRT-tst-gmon := $(csu-objpfx)gcrt1.o
>>>    tst-gmon-ENV := GMON_OUT_PREFIX=$(objpfx)tst-gmon.data
>>
>> Is this patch still needed?
> 
> Sure.

Shall I commit it, then?

Thanks,
Florian



More information about the Libc-alpha mailing list