[PATCH] i386: Use "movl main@GOT(%ebx), %eax" in start.S

H.J. Lu hjl.tools@gmail.com
Wed Oct 4 00:44:00 GMT 2017


On 10/3/17, H.J. Lu <hjl.tools@gmail.com> wrote:
> On 10/3/17, Florian Weimer <fw@deneb.enyo.de> wrote:
>> * H. J. Lu:
>>
>>> Don't use "leal main@GOTOFF(%ebx), %eax" since main may be in a
>>> shared object.  Linker will convert "movl main@GOT(%ebx), %eax"
>>> to "leal main@GOTOFF(%ebx), %eax" if main is defined locally.
>>>
>>> Any comments?
>>
>> Would it be worthwhile to add a test for this which is not
>> architecture-specific?
>>
>
> Yes, a patch is here:
>
> https://sourceware.org/ml/libc-alpha/2017-10/msg00104.html
>
>

I am checking it in.

-- 
H.J.



More information about the Libc-alpha mailing list