[PATCH] Add C++ versions of iscanonical for ldbl-96 and ldbl-128ibm

H.J. Lu hjl.tools@gmail.com
Tue Oct 3 23:59:00 GMT 2017


On 10/3/17, Gabriel F. T. Gomes <gabriel@inconstante.eti.br> wrote:
> On 03 Oct 2017, Joseph Myers wrote:
>
>>> +/* In C++ mode, __MATH_TG cannot be used, because it relies on
>>> +   __builtin_types_compatible_p, which is a C-only builtin.  On the
>>> +   other hand, overloading provides the means to distinguish between
>>> +   the floating-point types.  The overloading resolution will match
>>> +   the correct parameter (regardless of type qualifiers (i.e.: const
>>> +   and volatile).  */
>>
>>(twice in this patch, and once already in math.h) is missing a second
>>close parenthesis to match the first open parenthesis, and should be
>>fixed.
>
> Thanks.  Pushed with these changes.
>
>

On i686 wit GCC 7, I got

test-math-iscanonical.cc: In function ‘void check_type()’:
test-math-iscanonical.cc:33:11: error: use of an operand of type
‘bool’ in ‘operator++’ is deprecated [-Werror=deprecated]
     errors++;
           ^~
test-math-iscanonical.cc: In instantiation of ‘void check_type() [with
T = float]’:
test-math-iscanonical.cc:39:22:   required from here
test-math-iscanonical.cc:33:11: error: use of an operand of type
‘bool’ in ‘operator++’ is deprecated [-Werror=deprecated]
     errors++;
     ~~~~~~^~


-- 
H.J.



More information about the Libc-alpha mailing list