[PATCH] fix gamma symbol for static linking and new targets
Szabolcs Nagy
szabolcs.nagy@arm.com
Mon Oct 2 14:15:00 GMT 2017
On 29/09/17 18:56, Joseph Myers wrote:
> On Fri, 29 Sep 2017, Szabolcs Nagy wrote:
>> (at least i don't have those symbols after i rebase
>> the arm/ilp32 patches now, they used to come from
>> math/w_lgamma*_compat2.os)
>>
>> i don't think it's safe to remove them for new targets
>> since they are still in the public math.h
>
> I think that means new targets and static linking should get them from
> w_lgamma_template.c. That is, there should be w_lgamma.c, w_lgammaf.c and
> w_lgammal.c that include the template in the usual way then (for
> !LIBM_SVID_COMPAT) create the additional aliases (since we don't want the
> old versions of wrappers used on new targets - and as gamma is a Unix98
> interface, it should stay around, but as it's obsolescent, we don't want
> it for any _FloatN / _FloatNx types).
>
is this ok?:
The lgamma compat code is no longer built for !LIBM_SVID_COMPAT targets,
but the legacy gamma, gammaf and gammal symbols should be still defined,
so make them aliases to the non-compat lgamma code.
2017-10-02 Szabolcs Nagy <szabolcs.nagy@arm.com>
* math/w_lgamma.c: New file.
* math/w_lgammaf.c: New file.
* math/w_lgammal.c: New file.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gamma.diff
Type: text/x-patch
Size: 1067 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20171002/bdfe5e79/attachment.bin>
More information about the Libc-alpha
mailing list