[PATCH 18/58] Mark internal utmp functions with attribute_hidden [BZ #18822]
H.J. Lu
hjl.tools@gmail.com
Sun Oct 1 21:14:00 GMT 2017
On 9/2/17, Florian Weimer <fweimer@redhat.com> wrote:
> On 09/01/2017 07:59 PM, H.J. Lu wrote:
>> Mark internal utmp functions with attribute_hidden to allow direct
>> access within libc.so and libc.a without using GOT nor PLT.
>>
>> [BZ #18822]
>> * include/utmp.h (__updwtmp): Add attribute_hidden.
>> (__utmpname): Likewise.
>> (__getutent): Likewise.
>
> I believe this causes:
>
> /home/bmg/build/glibcs/s390-linux-gnu/glibc/login/utmpdump.o: In
> function `main':
> /home/bmg/build/glibcs/s390-linux-gnu/glibc-src/login/programs/utmpdump.c:93:
> undefined reference to `getutent'
> collect2: error: ld returned 1 exit status
>
> That's presumably due to the renaming business in
> sysdeps/unix/sysv/linux/s390/s390-32/getutent*.c
>
Here is the updated patch. Tested with build-many-glibcs.py. OK for master?
Thanks.
--
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0017-Mark-internal-utmp-functions-with-attribute_hidden-B.patch
Type: text/x-patch
Size: 4946 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20171001/0db884ad/attachment.bin>
More information about the Libc-alpha
mailing list