[PATCH] Properly compute offsets of note descriptor and next note [BZ #22370]

H.J. Lu hjl.tools@gmail.com
Thu Nov 16 13:24:00 GMT 2017


On Wed, Nov 15, 2017 at 3:03 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Sun, Nov 12, 2017 at 8:03 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>> On Nov 12 2017, "H.J. Lu" <hjl.tools@gmail.com> wrote:
>>
>>> Data after Elf64_Nhdr is the "name" field which is a 4-byte string, "GNU".
>>> There is no misalignment.
>>
>> That's not what your patch does.  You are aligning both the name length
>> and the data length to a 8 byte boundary, making the note size
>> unaligned.
>>
>
> You are right.  Both glibc and binutils get this wrong.  I opened a
> binutils bug:
>
> https://sourceware.org/bugzilla/show_bug.cgi?id=22444
>
> I will fix it first and take care of glibc next.
>

Here is the glibc path.

Any comments?

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Properly-compute-offsets-of-note-descriptor-and-next.patch
Type: text/x-patch
Size: 6893 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20171116/d6ec6558/attachment.bin>


More information about the Libc-alpha mailing list