[PATCH] add attribute nonstring
Florian Weimer
fweimer@redhat.com
Tue Nov 14 18:29:00 GMT 2017
On 11/14/2017 07:27 PM, Joseph Myers wrote:
> On Tue, 14 Nov 2017, Florian Weimer wrote:
>
>> However, the original patch should really use strnlen or memchr, and not
>> strlen. As posted, the strlen is either invalid because the array is not
>> NUL-terminated, or it passes because the string is short enough.
>
> if_nametoindex takes a char * argument. POSIX doesn't say explicitly, but
> I'd presume that must be a NUL-terminated string, with undefined behavior
> otherwise. That's separate from what the kernel interface is.
Oh, you are of course right. strlen is fine under these circumstances.
So the only thing that's missing is the __set_errno (ENODEV); call, I
think. (It's what the ioctl should fail with for an unknown interface
name.)
Thanks,
Florian
More information about the Libc-alpha
mailing list