[PATCH 3/3] aarch64: Hoist ZVA check out of the memset function

Siddhesh Poyarekar siddhesh@sourceware.org
Thu Nov 9 05:45:00 GMT 2017


On Thursday 09 November 2017 10:59 AM, Andrew Pinski wrote:
> I don't like this at all for the increase file size for the not so
> significant gain on real platforms.  I think we should declare falkor
> micro-arch is broken and move on.

Are you sure this doesn't give any gains for thunderx for the sizes I
mentioned (256B - ~1K)?  I see significant gains on mustang too and it
is obvious to see why; it is 3 instructions and a branch less in a hot
path and that should be significant regardless of the MRS cost.

If you don't see any gain then I don't mind posting this as a
falkor-specific change.  If you change your mind in future we can always
change the IFUNC condition.

Siddhesh



More information about the Libc-alpha mailing list