[PATCH 3/6] Simplify Linux sig{timed}wait{info} implementations

Zack Weinberg zackw@panix.com
Sun Nov 5 21:36:00 GMT 2017


On Fri, Nov 3, 2017 at 5:40 PM, Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
> This patch simplifies sig{timed}wait{info} by:
>
>   - Assuming __NR_rt_sigtimedwait existence on all architectures due minimum
>     kernel version requirement.

As with __NR_rt_sigqueueinfo, please document in the commit message
the oldest kernel version that provides __NR_rt_sigtimedwait on all
architectures.

>   - Add libc.so private __sigtimedwait symbol.

It is not apparent to me why this is necessary, please explain.

>         * sysdeps/unix/sysv/linux/sigwait.c (__sigwait): Call __sigtimedwait.
>         * sysdeps/unix/sysv/linux/sigwaitinfo.c (__sigwaitinfo): Likewise.

As with your sigpause/sigsuspend changes, please mention the addition
of LIBC_CANCEL_HANDLED annotations in the ChangeLog and add /*
__sigtimedwait handles cancellation */ comments above the
LIBC_CANCEL_HANDLED lines.

zw



More information about the Libc-alpha mailing list