[PATCH 6/6] Cleanup sigpause implementation

Zack Weinberg zackw@panix.com
Sun Nov 5 21:27:00 GMT 2017


On Fri, Nov 3, 2017 at 5:40 PM, Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
> This patch simplify sigpause by remobing the single thread optimization
> since it will be handled already by the __sigsuspend call.
>
> Checked on x86_64-linux-gnu.
>
>         * sysdeps/posix/sigpause.c (do_sigpause): Remove.
>         (__sigpause): Rely on __sigsuspend to implement single thread
>         optimization.

LGTM except that the addition of LIBC_CANCEL_HANDLED sent me down a
rabbit hole - I might have to write a replacement for
tst-cancel-wrappers.sh that doesn't depend on these magic markers -
anyway, please mention in the ChangeLog entry that you added this
annotation, and put /* __sigsuspend handles cancellation */
immediately above the LIBC_CANCEL_HANDLED line, following the pattern
of all the other uses of LIBC_CANCEL_HANDLED; that'll make things at
least a _little_ easier for future archaeologists.

zw



More information about the Libc-alpha mailing list