[PATCH] manual: Document the linkat function

Florian Weimer fweimer@redhat.com
Fri Nov 3 23:29:00 GMT 2017


On 11/03/2017 10:52 PM, Jonathan Nieder wrote:

>> --- a/manual/filesys.texi
>> +++ b/manual/filesys.texi
>> @@ -1205,6 +1205,35 @@ A hardware error occurred while trying to read or write the to filesystem.
>>   @end table
>>   @end deftypefun
>>   
>> +@deftypefun int linkat (int olfd, const char *@var{oldname}, int newfd, const char *@var{newname}, int flags)
> 
> s/olfd/oldfd/

Thanks, fixed.

> [...]
>> +@table @code
>> +@item AT_SYMLINK_FOLLOW
>> +If the source path denoted by @var{oldfd} and @var{oldname} is a
>> +symbolic link, @code{linkat} follows the symbolic link and creates a
> 
> usage nit: "denoted" does not seem like the right word.  Maybe
> "identified", to match the wording used above?

Okay, let's use identified.

> Or perhaps something
> like the following:
> 
> 	If the file @{oldname} in the directory associated to @var{oldfd}
> 	is a symbolic link, @code{linkat} follows the ...

That's not quite accurate because the name does not have to be located 
in that directory, it is only resolved relative to it.

> With whatever subset of the tweaks suggested above seems sensible,
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Pushed with the changes above.

Thanks,
Florian



More information about the Libc-alpha mailing list