[PATCH 1/7] Mark lazy tlsdesc helper functions unused to avoid warnings

[Szabolcs Nagy]

On 03/11/17 12:14, Florian Weimer wrote:
> On 10/24/2017 04:24 PM, Szabolcs Nagy wrote:
>> diff --git a/elf/tlsdeschtab.h b/elf/tlsdeschtab.h
>> index ad3001dac5..879631897c 100644
>> --- a/elf/tlsdeschtab.h
>> +++ b/elf/tlsdeschtab.h
>> @@ -137,6 +137,7 @@ _dl_make_tlsdesc_dynamic (struct link_map *map, size_t ti_offset)
>>      avoid introducing such dependencies.  */
>>     static int
>> +__attribute__ ((unused))
>>   _dl_tlsdesc_resolve_early_return_p (struct tlsdesc volatile *td, void *caller)
>>   {
>>     if (caller != atomic_load_relaxed (&td->entry))
>> @@ -155,6 +156,7 @@ _dl_tlsdesc_resolve_early_return_p (struct tlsdesc volatile *td, void *caller)
>>   }
>>     static void
>> +__attribute__ ((unused))
>>   _dl_tlsdesc_wake_up_held_fixups (void)
>>   {
>>     __rtld_lock_unlock_recursive (GL(dl_load_lock));
> 
> I think the preferred syntax is to put the attribute before the return type; after the type, it would apply to
> the type, and not the function, and GCC has hacks to support that, but that will only work for some types.
> 

hm.. current uses of unused attribute for the
same purpose come after the return type:

crypt/crypt_util.c
nptl/pthread_cond_common.c
stdio-common/_itowa.h
nis/nss-nisplus.h
sysdeps/unix/sysv/linux/dl-librecon.h
sysdeps/unix/sysv/linux/exit-thread.h
sysdeps/unix/sysv/linux/sigset-cvt-mask.h
sysdeps/*/dl-procinfo.h
sysdeps/*/dl-machine.h
sysdeps/unix/sysv/linux/*/dl-procinfo.h
iconv/gconv_charset.h
locale/elem-hash.h
locale/programs/locfile.h
nscd/nscd-client.h
posix/regex_internal.h
elf/get-dynamic-info.h

in fact the only cases where i see different
order is your code in:

resolv/resolv_context.h
malloc/dynarray-skeleton.c

(and even these two files use inconsistent
ordering)

> Otherwise, this looks okay to me.
> 
> Thanks,
> Florian