[PATCH] Reformat sysdeps/x86/libc-start.c

Florian Weimer fweimer@redhat.com
Thu Nov 2 18:40:00 GMT 2017


On 10/30/2017 11:12 PM, Jonathan Nieder wrote:
> Hi,
> 
> Carlos O'Donell wrote:
> 
>> Should we extend consensus?
>>
>> https://sourceware.org/glibc/wiki/Consensus#Trivial_Bug-Fix_Changes
>> ~~~
>> Anyone can commit a change fixing obvious coding standards problems
>> in a recently committed patch. Post the patch and ChangeLog to
>> libc-alpha with a short message and then push the commit.
>> ~~~
>> s/a recently/any/g
>>
>> We normally allow this kind of change for "recently committed"
>> patches, but shy away from it for older changes because of the impact
>> it might ave on established code.
>>
>> In this case I would have liked HJ to be able to just push the cleanup
>> without anyone *needing* to do a pre-commit review.
> 
> I would rather not --- getting LGTM is a pretty lightweight action,

I must say that I agree with Carlos here.  Even what should be a trivial 
review is often difficult to get, and a lot of cleanups land only 
because the author eventually commits their changes without review.

Thanks,
Florian



More information about the Libc-alpha mailing list