[PATCH] Consolidate code to get hwcap_mask into GET_HWCAP_MASK macro

Siddhesh Poyarekar siddhesh@sourceware.org
Mon May 22 18:21:00 GMT 2017


On Friday 19 May 2017 02:12 AM, Siddhesh Poyarekar wrote:
>        /* XXX The following is wrong!  Dave Miller rejected to implement it
>  	 correctly.  If this causes problems shoot *him*!  */
> -#ifdef SHARED
> -# if HAVE_TUNABLES
> -      uint64_t hwcap_mask = TUNABLE_GET (glibc, tune, hwcap_mask, uint64_t);
> -# else
> -      uint64_t hwcap_mask = GLRO(dl_hwcap_mask);
> -# endif
> +      uint64_t hwcap_mask = GET_HWCAP_MASK();

Ugh, this is so wrong, good thing I noticed before I would have got shot :)

I'll fix this up.

Siddhesh



More information about the Libc-alpha mailing list