[PATCH] mips: Fix store/load gp registers to/from ucontext_t

Joseph Myers joseph@codesourcery.com
Wed May 17 15:25:00 GMT 2017


Also: to store in / load from the right places, I'd expect you to need a 
4-byte offset on all the GPRs for big-endian, and when accessing other 
greg_t fields (in particular pc), so that the correct (low) part of each 
64-bit field is used.  I don't see such an offset in this patch.

I think that such a patch should be tested for all three ABIs, for both 
endiannesses, to provide confidence that the functions remain consistent 
with each other in all cases.  (For the 64-bit ABIs, it would be enough to 
verify that installed stripped shared libraries are unchanged before and 
after the patch; given that, it wouldn't be necessary to run the full 
testsuite for them.  But the full testsuite should be run for both BE and 
LE o32.)

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list