[PATCH 01/13] posix: Consolidate Linux pause syscall

Florian Weimer fweimer@redhat.com
Fri May 12 18:15:00 GMT 2017


On 05/12/2017 07:58 PM, Adhemerval Zanella wrote:
> +/* sparc64 defines __NR_pause,  however it is not supported (ENOSYS).
> +   Undefine so pause.c can use a correct alternative.  */
> +# ifdef __NR_pause
> +#  undef __NR_pause
> +# endif

I think you can #undef unconditionally, there isn't a warning for that.

+  return SYSCALL_CANCEL (ppoll, 0, 0, 0, 0, 0);

I think some of the arguments should be NULL instead of 0.

I'm not completely sure if an empty ppoll without a timeout has the 
required semantics, but I can't think of a reason why it would not work.

Thanks,
Florian



More information about the Libc-alpha mailing list