[PATCH v3 4/8] float128: Add public _Float128 declarations to libm.

[Gabriel F. T. Gomes]

On Tue, 9 May 2017 22:56:22 +0000
Joseph Myers <joseph@codesourcery.com> wrote:

> On Tue, 9 May 2017, Gabriel F. T. Gomes wrote:
>
> > --- /dev/null
> > +++ b/sysdeps/powerpc/powerpc64le/bits/floatn-compat.h  
> 
> GCC supports a range of multilib configurations with both BE and LE 
> libraries for powerpc64.
> 
> In such configurations, the same headers are shared between multilibs.  So 
> you can't have a separate version of an installed header for powerpc64le.  
> Instead, you need to have one header with appropriate preprocessor 
> conditionals that express that _Float128 is supported for powerpc64le, but 
> not for BE.  And it would go in sysdeps/powerpc so all powerpc 
> configurations get that same header installed.

OK.

> Or maybe nothing actually requires bits/floatn.h and bits/floatn-compat.h 
> to be separate and all the definitions should just go in bits/floatn.h 
> unless and until there are two architectures that need different versions 
> of one of the headers but the same version of the other.  That would avoid 
> various places needing to #include bits/floatn-compat.h, and avoid the 
> need to get includes in the correct order.

With bits/floatn.h moved from sysdeps/powerpc/powerpc64le to
sysdeps/powerpc (as explained above), merging bits/floatn-compat.h into
bits/floatn.h means that the workarounds for old compilers will be visible
in the headers for powerpc and powerpc64 installations.  That doesn't mean
that the workarounds will be defined (since they'll be inside #if
clauses).  Is that visibility a problem?

> > diff --git a/sysdeps/powerpc/powerpc64le/bits/floatn-compat.h b/sysdeps/powerpc/powerpc64le/bits/floatn-compat.h  
> 
> I think this file would better be in one of the patches actually adding 
> support on powerpc rather than in the present series, but I may as well 
> review the contents now.

Since I moved this change to a future patch.  I attached the file here in
case you want to comment at this time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: floatn.h
Type: text/x-chdr
Size: 3172 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20170511/00866e48/attachment.bin>