[PATCH 2/8] Consolidate Linux open implementation

Adhemerval Zanella adhemerval.zanella@linaro.org
Thu May 11 15:20:00 GMT 2017



On 11/05/2017 12:06, Andreas Schwab wrote:
> On Mai 08 2017, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
> 
>> This patch consolidates the open Linux syscall implementation on
>> sysdeps/unix/sysv/linux/open{64}.c.  The changes are:
>>
>>   1. Remove open{64} from auto-generation syscalls.list.
>>   2. Add a new open{64}.c implementation.  For architectures that
>>      define __OFF_T_MATCHES_OFF64_T the default open64 will create
>>      alias to required open symbols.
>>   3. Use __NR_open where possible, otherwise use __NR_openat.
> 
> Perhaps we should use __NR_openat unconditionally?  (Even 2.6.32 already
> had it.)
> 
> Andreas.
> 

I would prefer also, although using __NR_open is a marginal optimization 
(which I do not think it would mater).  I will change it.



More information about the Libc-alpha mailing list