Remove __ASSUME_STATFS_F_FLAGS

Joseph Myers joseph@codesourcery.com
Wed May 10 20:15:00 GMT 2017


On Wed, 10 May 2017, Florian Weimer wrote:

> On 05/10/2017 07:50 PM, Joseph Myers wrote:
> > -#ifndef __ASSUME_STATFS_F_FLAGS
> > -  if ((fsbuf->f_flags & ST_VALID) == 0)
> > -    /* Determining the flags is tricky.  We have to read /proc/mounts or
> > -       the /etc/mtab file and search for the entry which matches the given
> > -       file.  The way we can test for matching filesystem is using the
> > -       device number.  */
> > -    buf->f_flag = __statvfs_getflags (name, fsbuf->f_type, fd);
> > -  else
> > -#endif
> > -    buf->f_flag = fsbuf->f_flags ^ ST_VALID;
> > +  buf->f_flag = fsbuf->f_flags ^ ST_VALID;
> 
> Should we check the presence of the flag and return ENOSYS or abort if it
> missing?

I don't know.  Not in this patch, which is meant only to clean up dead 
code without changing the generated code.

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list