[PATCH 02/10] Suppress internal declarations for most of the testsuite.

Joseph Myers joseph@codesourcery.com
Tue May 9 21:28:00 GMT 2017


On Tue, 9 May 2017, Zack Weinberg wrote:

> diff --git a/stdlib/tst-strtod1i.c b/stdlib/tst-strtod1i.c
> new file mode 100644
> index 0000000000..d8a952f606
> --- /dev/null
> +++ b/stdlib/tst-strtod1i.c
> @@ -0,0 +1,83 @@
> +/* Copyright (C) 1991-2017 Free Software Foundation, Inc.

Should have descriptive comment before the copyright notice.

> diff --git a/stdlib/tst-strtod5.c b/stdlib/tst-strtod5.c
> index 337c746989..d53b17c51a 100644
> --- a/stdlib/tst-strtod5.c
> +++ b/stdlib/tst-strtod5.c
> @@ -1,3 +1,20 @@
> +/* Copyright (C) 2007-2017 Free Software Foundation, Inc.

Likewise.

> diff --git a/stdlib/tst-strtod5i.c b/stdlib/tst-strtod5i.c
> new file mode 100644
> index 0000000000..e9489c1747
> --- /dev/null
> +++ b/stdlib/tst-strtod5i.c
> @@ -0,0 +1,99 @@
> +/* Copyright (C) 2007-2017 Free Software Foundation, Inc.

Likewise.

The patch is OK with those changes, provided you've verified unchanged 
installed stripped shared libraries on at least one platform (unless 
there's some reason for the libraries to change), and an unchanged set of 
tests run on at least one platform (except for any deliberate changes such 
as from splitting strtod tests).

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list