[PATCH 2/4] nptl: Using libsupport for tst-cancel4*
Florian Weimer
fweimer@redhat.com
Mon May 1 17:18:00 GMT 2017
On 04/27/2017 11:30 PM, Adhemerval Zanella wrote:
> r = pthread_barrier_wait (&b2);
> if (r != 0 && r != PTHREAD_BARRIER_SERIAL_THREAD)
> - {
> - printf ("%s: barrier_wait failed\n", __FUNCTION__);
> - exit (1);
> - }
> + FAIL_EXIT1 ("pthread_barrier_wait");
> }
Just a quick comment that we already have xpthread_barrier_wait and
xmmap, so you could use them for error checking. There are also strdup
calls which should be xstrdup.
Thanks,
Florian
More information about the Libc-alpha
mailing list