[PATCH v2] posix_spawn: use a larger min stack for -fstack-check [BZ #21253]

Dmitry V. Levin ldv@altlinux.org
Fri Mar 17 20:49:00 GMT 2017


On Fri, Mar 17, 2017 at 09:19:24PM +0100, Andreas Schwab wrote:
> On Mär 17 2017, Mike Frysinger <vapier@gentoo.org> wrote:
> 
> > On 17 Mar 2017 12:09, Mike Frysinger wrote:
> >> -  size_t stack_size = ALIGN_UP (argv_size, GLRO(dl_pagesize));
> >> +  size_t stack_size = ALIGN_UP (argv_size, GLRO (dl_pagesize));
> >
> > guess the diff can be a little confusing -- i just fixed spacing here.
> 
> The spacing wasn't wrong.


$ git grep 'GLRO (' [^C]* | wc -l
30
$ git grep 'GLRO(' [^C]* | wc -l
524


The tradition is obviously in favour of the latter variant, but why?




-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20170317/023f8448/attachment.sig>


More information about the Libc-alpha mailing list