[PATCH v2] Add page tests to string/test-strnlen.

Mike Frysinger vapier@gentoo.org
Fri Mar 17 02:59:00 GMT 2017


On 15 Mar 2017 15:00, Wainer dos Santos Moschetta wrote:
> +  for (i = 0; i < last_offset; i++)
> +    s[i] = 65;

memset ?

> +      FOR_EACH_IMPL (impl, 0)
> +          /* Checks only for maxlen larger than length because other cases are
> +             already covered in do_random_tests.  */
> +          do_one_test (impl, (CHAR *) (s + offset), page_size, exp_len);

incorrect indent.  but please use braces as it'll be less confusing
(especially with that comment in there).
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20170317/2e2c2f1e/attachment.sig>


More information about the Libc-alpha mailing list