[PATCH] Fix test-errno issues

[Adhemerval Zanella]

On 14/03/2017 17:13, Mike Frysinger wrote:
> On 13 Mar 2017 11:21, Adhemerval Zanella wrote:
>> This patch fixes multiple issues of test-errno.c (9a56f8718341):
>>
>>   - Rename Linux test-errno.c to test-errno-linux.c to avoid build
>>     the same source for both tests.
>>
>>   - Add a mlock check for 32 bits build running on 64 bits kernels.
>>     Althuough man pages states that mlock fails with EINVAL if final
>>     address overflows, kernels does not return it for aforementioned
>>     condition (it returns ENOMEM instead).  Although it seems to be
>>     a kernel issue for compat syscall handling, I think it is worth
>>     to still check syscall return and document the behavior.
>>
>>   - Initialize option lenght for setsockopt check.
> 
> "length"
> 
>>  ChangeLog                                  |   8 ++
>>  posix/test-errno.c                         |   2 +-
>>  sysdeps/unix/sysv/linux/Makefile           |   2 +-
>>  sysdeps/unix/sysv/linux/test-errno-linux.c | 176 +++++++++++++++++++++++++++++
>>  sysdeps/unix/sysv/linux/test-errno.c       | 142 -----------------------
>>  5 files changed, 186 insertions(+), 144 deletions(-)
>>  create mode 100644 sysdeps/unix/sysv/linux/test-errno-linux.c
>>  delete mode 100644 sysdeps/unix/sysv/linux/test-errno.c
> 
> if you use -C -M with send-email, then the diff below would show
> a rename+changes instead of one large delete and one large create.
> as-is, it's hard to review.
> 
> i use this in my ~/.gitconfig:
> [alias]
> 	fp = format-patch -C -M
> 	se = send-email -C -M
> 
> this way `git se` will always include -C -M for me.
> -mike
> 

Thanks, I will send a v2 for this patch and I will make sure to use
these options.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20170314/17a78f0d/attachment.sig>