[PATCH v4] configure.ac: Avoid empty subexpression in grep
Alexey Neyman
stilor@att.net
Sun Mar 12 20:25:00 GMT 2017
On 03/12/2017 11:29 AM, Paul Eggert wrote:
> Alexey Neyman wrote:
>>>
>>>> replace all the /dev/null redirects with a -q flag.
>>>
>>> That also works.
>>>
>> Version 3 of the patch attached.
>
> Hmm, sorry, I forgot about this issue:
>
> https://bugs.gnu.org/24941
>
> The problem is that in many cases
>
> FOO | grep -q BAR
>
> will cause FOO to output a "Broken pipe" diagnostic, whereas
>
> FOO | grep BAR >/dev/null
>
> will be quiet (and also less efficient, but nobody cares about
> performance here). So perhaps we'd better avoid the
> /dev/null-to-minus-q part of the change, and stick to just fixing the
> bug at hand for now.
>
v4 attached. Using ERE and 'grep -F' instead of fgrep.
Regards,
Alexey.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v4-0001-Fix-combreloc-test-with-BSD-grep.patch
Type: text/x-patch
Size: 2887 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20170312/fbeb61c9/attachment.bin>
More information about the Libc-alpha
mailing list