[PATCH 3/4] Miscellaneous 'safe' testsuite changes.

Andreas Schwab schwab@linux-m68k.org
Thu Mar 2 13:57:00 GMT 2017


On Feb 26 2017, Zack Weinberg <zackw@panix.com> wrote:

> diff --git a/elf/get-dynamic-info.h b/elf/get-dynamic-info.h
> index 86760d8844..6413558975 100644
> --- a/elf/get-dynamic-info.h
> +++ b/elf/get-dynamic-info.h
> @@ -16,8 +16,11 @@
>     License along with the GNU C Library; if not, see
>     <http://www.gnu.org/licenses/>.  */
>  
> +#ifndef _GET_DYNAMIC_INFO_H
> +#define _GET_DYNAMIC_INFO_H 1
> +
>  #include <assert.h>
> -#include <libc-internal.h>
> +#include <libc-diag.h>
>  
>  #ifndef RESOLVE_MAP
>  static
> @@ -179,3 +182,5 @@ elf_get_dynamic_info (struct link_map *l, ElfW(Dyn) *temp)
>      info[DT_RPATH] = NULL;
>  #endif
>  }
> +
> +#endif /* get-dynamic-info.h */

This is bogus.  The file must be included multiple times, depending on
the definition of RESOLVE_MAP.

This breaks powerpc
<https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:glibc/glibc/p/ppc>.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."



More information about the Libc-alpha mailing list