[PATCH] float128: Add signbit alternative for old compilers

Joseph Myers joseph@codesourcery.com
Fri Jun 30 21:00:00 GMT 2017


On Fri, 30 Jun 2017, Gabriel F. T. Gomes wrote:

> On Fri, 30 Jun 2017 20:40:25 +0000
> Joseph Myers <joseph@codesourcery.com> wrote:
> 
> > On Fri, 30 Jun 2017, Gabriel F. T. Gomes wrote:
> > 
> > > +int
> > > +__signbitf128 (_Float128 x)
> > > +{
> > > +  int64_t e;
> > > +
> > > +  GET_FLOAT128_MSW64 (e, x);
> > > +  return e < 0;  
> > 
> > I think you should use __builtin_signbit for GCC >= 6 with a comment that 
> > once GCC >= 6 is required for building glibc, this file can go back to 
> > wrapping the float128 version.
> 
> OK.
> 
> > OK with that change.
> 
> Is this OK to go in now, before the freeze?

Yes.

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list