[PATCH] Avoid .symver on common symbols [BZ #21666]

Florian Weimer fweimer@redhat.com
Fri Jun 23 16:17:00 GMT 2017


On 06/23/2017 06:11 PM, H.J. Lu wrote:
> +/* Define the variables used for the interface.  Avoid .symver on common
> +   symbol, which just creates a new common symbol, not an alias.  */
> +char *loc1 = NULL;
> +char *loc2 = NULL;

I think __attribute__ ((nocommon)) without the initializer would be more
explicit.  We already use that for _res in resolv/res_libc.c.

Does this result in a visible difference for applications?  If yes,
please file a bug for this and reference it in the ChangeLog and commit
message.

Why didn't our test suite catch it?

Thanks,
Florian



More information about the Libc-alpha mailing list