[PATCH] x86-64: memcmp-avx2-movbe.S needs saturating subtraction [BZ #21662]

Florian Weimer fweimer@redhat.com
Fri Jun 23 15:12:00 GMT 2017


On 06/23/2017 05:08 PM, H.J. Lu wrote:
> On Fri, Jun 23, 2017 at 6:51 AM, Florian Weimer <fweimer@redhat.com> wrote:
>> I think this revised patch is an improvement because it avoids adding a
>> branch.
>>
>> Thanks,
>> Florian
> 
> The memcmp-avx2-movbe.S part is OK.

Thanks, I will commit it shortly.

> For
> 
> (check_result, do_random_tests): Write error messages to standard
> output.
> 
> any particular reason to replace error with printf?

The error function writes to standard error, so the test harness does
not capture it output in the .out file.

Thanks,
Florian



More information about the Libc-alpha mailing list