[RFC PATCH] Remove bits/string.h.

[Wilco Dijkstra]

Zack Weinberg wrote:
> On Wed, Jun 21, 2017 at 8:48 AM, Wilco Dijkstra <Wilco.Dijkstra@arm.com> wrote:
> > Florian Weimer wrote:
>>>
>>> What's the contents of your libc-pic.a library?  Does it contain a
>>> mempcpy.os?
>>
>> Yes it does. Anyway I've confirmed the underlying cause. It is the removal of
>> the mempcpy inline. If I revert that or add it again, GLIBC builds again for AArch64.
>
> But GLIBC builds just fine for me (in cross compilation) for AArch64,
> so there must be more to it than that.

Szabolcs couldn't reproduce it natively with a similar setup either. It turned out I had
an old unused mempcpy.s/mempcpy.o in the string source directory which somehow
causes make to skip building rtld-mempcpy.os rather than give an error that there are
multiple files that build into the same object...

So it builds again! However we still need to do something about the inlining of mempcpy
given that GCC doesn't optimize it at all while GLIBC uses it a lot...

Wilco