[PATCH] tunables: Add IFUNC selection and cache sizes
H.J. Lu
hjl.tools@gmail.com
Wed Jun 21 14:51:00 GMT 2017
On Wed, Jun 21, 2017 at 7:35 AM, Siddhesh Poyarekar <siddhesh@gotplt.org> wrote:
> On Wednesday 21 June 2017 06:56 PM, H.J. Lu wrote:
>> I am testing this patch. OK for master if there are no regressions?
>>
>
> Looks OK to me with one comment change which I missed the last time:
>
>> Since all CPU/ARCH features are hardware optimizations without
>> security implication, except for Prefer_MAP_32BIT_EXEC, which can
>> - only be disabled, we check GLIBC_IFUNC for programs, including
>> + only be disabled, we check glibc.tune.hwcaps for programs, including
>> set*id ones.
>
> This block is no longer valid since the tunables are not read for setxid
> binaries. If you want to make a case for hwcaps to be read in setxid
> binaries, then it should be made along with hwcap_mask since they're
> essentially the same feature for different machines.
>
Here is the updated patch. OK for master?
--
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Move-x86-specific-tunables-to-x86-dl-tunables.list.patch
Type: text/x-patch
Size: 2370 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20170621/294dac1d/attachment.bin>
More information about the Libc-alpha
mailing list