[PATCH v3] mips: Fix store/load gp registers to/from ucontext_t

Gordana Cmiljanovic Gordana.Cmiljanovic@imgtec.com
Tue Jun 13 11:51:00 GMT 2017


Modified according to comments:
 - sysdep_routine not needed
 - formatting according to GNU Coding Standards

Regards,
Gordana
________________________________________
From: Joseph Myers [joseph@codesourcery.com]
Sent: Wednesday, June 07, 2017 10:15 PM
To: Gordana Cmiljanovic
Cc: libc-alpha@sourceware.org; Petar Jovanovic
Subject: Re: [PATCH v2] mips: Fix store/load gp registers to/from ucontext_t

You should not need the addition to sysdep_routines.  If you do need it,
please explain why in detail.

The testcase should start with the standard copyright and license notices.
It should be formatted according to the GNU Coding Standards (e.g. spaces
before '(' in function calls, operators at start not end of line when an
expression spans multiple lines).  "# error" for conditional #error, not
"   #error".  support/test-driver.c (see support/README-testing.c) should
be used instead of the old test-skeleton.c.

--
Joseph S. Myers
joseph@codesourcery.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mips-Fix-store-load-gp-registers-to-from-ucontext_t-v3.patch
Type: text/x-patch
Size: 16972 bytes
Desc: mips-Fix-store-load-gp-registers-to-from-ucontext_t-v3.patch
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20170613/87e2bd43/attachment.bin>


More information about the Libc-alpha mailing list