[RFC][PATCH 0/2] aarch64: Add optimized ASIMD versions of sinf/cosf

Wilco Dijkstra Wilco.Dijkstra@arm.com
Tue Jun 13 10:57:00 GMT 2017


Ashwin wrote:
> Please find the microbenchmark code at  
> https://github.com/ashwinyes/glibc_microbenchmarks/blob/master/sinf/sinf_benchmark.c

That is fine for benchmarking the individual code paths of a specific implementation.

However a good benchmark would run through a representative subset of calls from
actual code rather than repeating the same input many times. This avoids focusing too
much on special cases that never occur in the real world or failing to take the cost of
branch mispredictions into account due to varying inputs.

Wilco



More information about the Libc-alpha mailing list